Add callbacks for when the Done button is tapped#643
Open
jsahoo wants to merge 1 commit intoTimOliver:mainfrom
Open
Add callbacks for when the Done button is tapped#643jsahoo wants to merge 1 commit intoTimOliver:mainfrom
jsahoo wants to merge 1 commit intoTimOliver:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a delegate method and completion handler that are called when the Done button is tapped. This is useful for displaying an activity indicator or HUD while the newly cropped image is being created (as this can sometimes take a second or two with large images), or for tracking button tap analytics.
Example Usage (Delegate)
Example Usage (Completion Handler)